build-canaries / nevergreen

:baby_chick: A build monitor with attitude
https://nevergreen.io
Eclipse Public License 1.0
215 stars 38 forks source link

[a11y] aria-hidden elements do not contain focusable elements #291

Closed GentlemanHal closed 3 years ago

GentlemanHal commented 5 years ago

https://dequeuniversity.com/rules/axe/3.3/aria-hidden-focus

This is reported when a model is open, for example help or change auth in the tray settings.

I'm not sure if this is actually a problem as the model traps tabbing to keep it in the model and clicking the background closes the model.

GentlemanHal commented 4 years ago

I created a stack overflow question https://stackoverflow.com/questions/62677291/aria-hidden-elements-do-not-contain-focusable-elements-issue-when-modal-is-sho

GentlemanHal commented 3 years ago

This seems to have stopped happening after updating cypress and/or cypress-axe (I updated both at the same time), so I'm going to close this for now.