search

build-canaries / nevergreen

:baby_chick: A build monitor with attitude
https://nevergreen.io
Eclipse Public License 1.0
215 stars 38 forks source link

Added Reset Configuration Feature #295

Closed tharun208 closed 4 years ago

tharun208 commented 5 years ago

Fixes issue #149

@build-canaries/owners

tharun208 commented 5 years ago

sure @GentlemanHal

tharun208 commented 5 years ago

@GentlemanHal, To do make it simple can I spy on the resetConfiguration method. So, It can cover both of the functions inside it

GentlemanHal commented 5 years ago

@GentlemanHal, To do make it simple can I spy on the resetConfiguration method. So, It can cover both of the functions inside it

No because that is the function under test! Spying on that means someone could delete the contents of the function but the test would still pass 😱

If you are having trouble spying on the window reload, let me know and I can update the test after it's merged.

tharun208 commented 5 years ago

Hi @GentlemanHal, I have made the changes and updated the test to spy on both the clear and reload functions

GentlemanHal commented 4 years ago

I've rebased the changes back onto master, thanks @tharun208!

The styling was broken so I made a few changes.