search

build-canaries / nevergreen

:baby_chick: A build monitor with attitude
https://nevergreen.io
Eclipse Public License 1.0
215 stars 38 forks source link

The pre push script doesn't always stop the servers #305

Open GentlemanHal opened 4 years ago

GentlemanHal commented 4 years ago

Bug report

Expected behaviour? Once the ./pre-push.sh has finished running the Nevergreen server and the CCTray XML mock server should no longer be running.

Actual behaviour? Sometimes the servers (possibly just the CCTray XML mock server) are still running and attempting to run the develop script or pre push again results in an error when they try to start the servers again.

Steps to reproduce?

  1. Not sure

I think it might happen if the journey tests fail ⁉️

GentlemanHal commented 6 months ago

I think the best approach for this is to make better use of npm scripts and tools such as concurrently

My comment from the PR:

If this was a pure node project we'd be making better use of npm commands and tools like concurrently. We didn't originally as it's a mixed repo and the client used to be quite simple. Now the client is much more complex and most features are client side nowadays.

So treating it like a node project and doing more via npm would probably make sense to most people contributing. I'm assuming we can easily call lein via npm to build/run/test/etc the server side stuff? 🤔

I wondering if this would be more reliable/easier than bash scripts?