build-canaries / nevergreen

:baby_chick: A build monitor with attitude
https://nevergreen.io
Eclipse Public License 1.0
215 stars 38 forks source link

All keyboard shortcuts still work when models are open #311

Closed GentlemanHal closed 4 years ago

GentlemanHal commented 4 years ago

Bug report

Nevergreen version? v5.0.1+2138.4e4099f Plump Purple

What are you running on? Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36

Expected behaviour? Only keyboard shortcuts that operate within or on the model should work (such as esc).

Actual behaviour? All keyboard shortcuts continue to work even those that operate on the page being covered by the model.

Steps to reproduce?

  1. Open the help model
  2. Use any keyboard shortcut, such as navigation 1, 2 etc