build-trust / ockam

Orchestrate end-to-end encryption, cryptographic identities, mutual authentication, and authorization policies between distributed applications – at massive scale.
https://ockam.io
Apache License 2.0
4.45k stars 559 forks source link

Move `multiaddr_to_route` to `NodeManager` #4388

Open adrianbenavides opened 1 year ago

adrianbenavides commented 1 year ago

ref: https://github.com/build-trust/ockam/pull/4172#discussion_r1119863015

This means that many calls in ockam_api files will look like:

let cloud_route = self.multiaddr_to_route(req_wrapper.multiaddr()?).await?;

We love helping new contributors! If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion. If you're looking for other issues to contribute to, checkout this discussion and labels - https://github.com/build-trust/ockam/labels/good%20first%20issue or https://github.com/build-trust/ockam/labels/help%20wanted

0xkelvin commented 1 year ago

@adrianbenavides please assign to me

0xkelvin commented 1 year ago

@adrianbenavides is it still valid for me

adrianbenavides commented 1 year ago

Sure! I was reviewing the work to be done here and I noticed we use the multiaddr_to_route as a static function outside of the ockam_api crate, so we should end up with two methods:

Let us know if you need help or have any question along the way!