build-trust / ockam

Orchestrate end-to-end encryption, cryptographic identities, mutual authentication, and authorization policies between distributed applications – at massive scale.
https://ockam.io
Apache License 2.0
4.47k stars 562 forks source link

Make `ockam vault show` (no args) interactive by asking the user to choose from a list of vaults to show (tuify) #6474

Closed nazmulidris closed 1 year ago

nazmulidris commented 1 year ago

Current behavior

When a user runs ockam vault show without any arguments, currently they are shown an error if there are no vaults:

Image

Or the default vault if there is a default one:

Image

Desired behavior

Change the behavior of this command so that it becomes interactive with the user when no arguments are passed. Note that this can only be allowed to happen if:

This what the user flow should look like in interactive mode.

1) Use the tuify crate's select_from_list() function to ask the user to select from a list of vault names. They should be able to make multiple selections. If there are none, then simply display a message saying that none exist (not an error) and exit.

2) Once the user has made their selection(s), then run show for each selected vault, and display the results of the show command for each vault that they've selected.

The following is a video showing a generic user flow that shows the user experience when a user is asked to choose a from a list of "things". Then an action is performed on each "thing". Finally status information is reported for each action that is performed on each "thing". Please note that this flow is not specific to this issue. Image https://asciinema.org/a/612547

Implementation details


We love helping new contributors! ❤️ If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

abhiramtilakiiit commented 1 year ago

Can you assign this to me?

mrinalwadhwa commented 1 year ago

@abhiramtilakiiit of course, all yours.

Please let us know if your have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds