Open nazmulidris opened 1 year ago
hey, I would like to try this. Pls assign me!
@Himanshu-370 That's awesome, this is all yours. Please let us know if you have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds
@Himanshu-370 Since you started working on this issue here's some new information that help you w/ your PR:
Please use the functions select_multiple
, and confirm_interactively
in this file.
Here's a similar PR to get some ideas from: https://github.com/build-trust/ockam/pull/6480
@Himanshu-370 Since you started working on this issue here's some new information that help you w/ your PR:
- Please use the functions
select_multiple
, andconfirm_interactively
in this file.- Here's a similar PR to get some ideas from: delete node interactively #6480
Thanks, working on it:)
@Himanshu-370 We made a minor UX (user experience) update to the issue today. Instead of asking a user for confirmation once they've made their selection, we can just skip that and allow them to perform the action. Since the action is not destructive, it results in a better UX for the user.
If this issue is not yet done, please, can you assign it to me?
@Lumexralph It is all yours 👍🏽
@Lumexralph It is all yours 👍🏽
got a PR in for this issue #6968, my next focus will be on the other assigned issue.
Current behavior
When a user runs
ockam tcp-outlet show
without any arguments, currently they are shown an error message & help text. Here's a screenshot of this.Desired behavior
Change the behavior of this command so that it becomes interactive with the user when no arguments are passed. Note that this can only be allowed to happen if:
--no-input
or--quiet
flags have not been passed, and,This what the user flow should look like in interactive mode.
1) Use the tuify crate's
select_from_list()
function to ask the user to select from a list of tcp-outlet aliases, at the default node. They should be able to make multiple selections. If there are none, then simply display a message saying that none exist (not an error) and exit.2) Once the user has made their selection(s), then run
show
for each selected tcp-outlets, and display the results of theshow
command for each tcp-outlets that they've selected.Implementation details
Please use the functions
select_multiple
, andconfirm_interactively
in this file.Here's a similar PR to get some ideas from: https://github.com/build-trust/ockam/pull/6480
You can learn more about how to use the
select_from_list()
in the tuify crate here. Here is an example that is very similar to the steps you might have to take for this issue.Here's a file you can look at to detect when a terminal is interactive or not.
Here's a file you can look at to see where the
ockam tcp-outlet show
command is implemented.We love helping new contributors! ❤️ If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.