build2-packaging / SimpleBLE

build2 packages for SimpleBLE
MIT License
0 stars 0 forks source link

List library prerequisites after sources #3

Closed boris-kolpackov closed 1 year ago

boris-kolpackov commented 1 year ago

In libsimpleble/src/buildfile there is this fragment:

lib{simpleble}: $pub/{$pub_hdrs}
lib{simpleble}: {hxx cxx}{*}
lib{simpleble}: builders/{hxx cxx}{*}
lib{simpleble}: external/hxx{*.hpp}
lib{simpleble}: $impl_libs $intf_libs

lib{simpleble}: linux/{hxx cxx}{*}: include = $is_linux
lib{simpleble}: windows/{hxx cxx}{*}: include = $is_windows
lib{simpleble}: macos/{hxx cxx mm}{*}: include = $is_macos

Usually you would want to list libraries last since the order matters if linking static libraries:

lib{simpleble}: $pub/{$pub_hdrs}
lib{simpleble}: {hxx cxx}{*}
lib{simpleble}: builders/{hxx cxx}{*}
lib{simpleble}: external/hxx{*.hpp}

lib{simpleble}: linux/{hxx cxx}{*}: include = $is_linux
lib{simpleble}: windows/{hxx cxx}{*}: include = $is_windows
lib{simpleble}: macos/{hxx cxx mm}{*}: include = $is_macos

lib{simpleble}: $impl_libs $intf_libs

In this case specifically, it looks like the linux/ source code could depend on symbols from libsimplebluez.

P.S. I've migrated the 0.5.0 packages from queue.stage to public so if you want to publish a revision, send it to the usual place instead of stage.build2.org.

Rookfighter commented 1 year ago

Thanks, new revision submitted.

boris-kolpackov commented 1 year ago

Published, thanks!