search

build2-packaging / glfw

build2 package for glfw
0 stars 1 forks source link

Change c.std value to standard c99 #11

Closed wroyca closed 5 months ago

wroyca commented 5 months ago

Closes https://github.com/build2-packaging/glfw/issues/10

Looking at the source, they use proper #define to manage with and/or without GNU extension

CI

helmesjo commented 5 months ago

@boris-kolpackov Is this good to go? Looked quickly and there are a few warnings that probably should be taken care of, but they seem unrelated to this PR anyways:

warning: multiple files are distributed as redist/glfw-3.3.8/src/context.c
  info: second file is dist/glfw-3.3.8/src/context.c
  info: this warning will become error in the future
wroyca commented 5 months ago

@boris-kolpackov Is this good to go? Looked quickly and there are a few warnings that probably should be taken care of, but they seem unrelated to this PR anyways:

warning: multiple files are distributed as redist/glfw-3.3.8/src/context.c
  info: second file is dist/glfw-3.3.8/src/context.c
  info: this warning will become error in the future

but they seem unrelated to this PR anyways:

They are indeed unrelated, so I opted to leave them as-is for this PR :+1:

boris-kolpackov commented 5 months ago

Looks good to me. Someone just needs to merge this and release and publish a revision.

boris-kolpackov commented 4 months ago

@Swat-SomeBug Thanks for merging and releasing the 3.3.8+1 revision! It is now published to the testing section of cppget.org: https://cppget.org/glfw/