search

build2-packaging / glfw

build2 package for glfw
0 stars 1 forks source link

Update to GLFW 3.4 #13

Open monomere opened 1 month ago

monomere commented 1 month ago

This should close #12 I'm not sure if I did everything right, I can and will fix any issues with this pr.

monomere commented 1 month ago

I'm not sure about the statically linking vulkan option...

monomere commented 1 month ago

Wanted to add that I changed the email to mine in some files as a temporary thing because the package was in my fork (now they should be changed to whatever it appropriate)

wroyca commented 1 month ago

Thank for the fix! @monomere

Could you run bdep ci and post the link here so that we can investigate issues (if any) from tests?

monomere commented 1 month ago

The tests should be changed since there need to be tests for Wayland + X11, just Wayland, just X11, MacOS, and Windows. OSMesa isn't needed as GLFW removed it. Should I just run bdep ci in the repo? I'm not familiar with the build2 ci infrastructure :see_no_evil:

wroyca commented 1 month ago

The tests should be changed since there need to be tests for Wayland + X11, just Wayland, just X11, MacOS, and Windows. OSMesa isn't needed as GLFW removed it. Should I just run bdep ci in the repo? I'm not familiar with the build2 ci infrastructure 🙈

Should I just run bdep ci in the repo?

Yup. \:)

Note that you must first initialize the project in a build configuration (e.g.):

bdep init -C @gcc cc

and then you'll be able to run bdep ci

monomere commented 1 month ago

I'll do this tomorrow! A bit too late for me right now :-)

By the way, how are the tests configured? E.g. the unix builds need to have libwayland-dev/wayland-protocols installed

wroyca commented 1 month ago

By the way, how are the tests configured?

This question is tricky, and I'm not personally confident enough to answer it; I recommend asking on https://cpplang.slack.com/app_redirect?channel=build2 (or users@build2.org) where someone more knowledgeable might be able to answer you :)

monomere commented 3 days ago

Sorry for the long delay, I think I will finally have the time to start working on this again!