search

build2-packaging / imgui

Build2 package for imgui
Other
2 stars 5 forks source link

Bump version to 1.90.6 #18

Closed wroyca closed 1 month ago

wroyca commented 1 month ago

Nothing much to say here, this is just the usual version bump. ☕

wroyca commented 1 month ago

Failure with Ubuntu (clang) is due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110970. Already fixed upstream but CI is a little behind.

wroyca commented 1 month ago

soft ping @Rookfighter @boris-kolpackov to know if Ubuntu (clang) CI failing due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110970 is something you considers blocking / problematic. :pray:

Rookfighter commented 1 month ago

I think this is acceptable. The Ubuntu runners are configured as latest, so as soon as latest is moved to Ubuntu 24.04 the problem should be gone anyway. IMO the GitHub Actions just act as simple smoke test. since most of them succeed and the failure reason of the others is known, I think there is no need to invest any time in fixing the build right now.

wroyca commented 1 month ago

I think this is acceptable. The Ubuntu runners are configured as latest, so as soon as latest is moved to Ubuntu 24.04 the problem should be gone anyway. IMO the GitHub Actions just act as simple smoke test. since most of them succeed and the failure reason of the others is known, I think there is no need to invest any time in fixing the build right now.

Sweet! I also see that boris also reacted with a thumb up, so that PR is good to go on my side, one thing is that I don't own a mac to test locally, so I'll have to trust the CI here; in any case, let me know if I missed anything :+1:

wroyca commented 1 month ago

Soft ping, @Rookfighter, was there a chance publishing the revision slipped your mind? No pressure if time didn't permit—just checking in! :)