build2-packaging / imgui

Build2 package for imgui
Other
2 stars 5 forks source link

Publish "docking" packages #23

Open Klaim opened 6 days ago

Klaim commented 6 days ago

We just merged the docking upstream branch packages #19

Now we need to publish them to cppget (as a revision I suppose?)

I will proceed this weekend if @Rookfighter isn't around 👍🏽

Rookfighter commented 6 days ago

Yeah, feel free to go ahead. I am on vacation, so I won't find the time to publish. IMO revision +1 is the way to go

Klaim commented 6 days ago

Ok then I'll proceed soon 👍🏽

Klaim commented 5 days ago

Revision release tag done: https://github.com/build2-packaging/imgui/releases/tag/v1.90.8%2B1

Klaim commented 5 days ago

Revision release submitted:

A few additional notes: This revision adds the docking packages, therefore it was theorically not necessary to add revision versions to the non-docking packages. In the same way of thinking, it was not necessary to mark the docking packages versions as revisions. However, because these are all in the same repository and we want to keep things simple, I opted into not doing anything special about that and letting packages versions strictly match the related tagged git commit. Worse case, package reviewers could just ignore the revision packages of the non-docking packages, it wouldnt change a thing for users.

Before publishing I double checked at least on Windows by building in configurations for msvc with debug and release kind of set of flags. Obviously in that context I couldnt build and test the osx platform packages nor the metal rendering packages, but it was still necessary to initialize these in the configurations to be able to bdep publish. FYI.

wroyca commented 3 days ago

From #24, this is now fixed with a revision but still needs to be published, for which I lack permission. @Klaim and myself will be unavailable for a couple of days, so if anyone wants to chime in and publish (taking they have the permission). Go for it :)

cc @boris

also deploying on Friday, what could possibly go wrong?