search

buildar / getting_started_with_webrtc

Example code to help you get started creating WebRTC applications
MIT License
79 stars 39 forks source link

Up #5

Closed kevinkoda closed 9 years ago

kevinkoda commented 9 years ago

edited

robman commented 9 years ago

Hi @kevinkoda we won't accept this pull request as none of the changes I can see are actually improving or extending this code.

In fact in at least 2 places you have removed the reference to our authorship which is a breach under the open source license - please restore this attribution if you intend to keep using this code.

The other changes are adding things like your fixed ip address and port. This is obviously something each user should set and a fixed ip address shouldn't be included in this type of example code.

kevinkoda commented 9 years ago

Sorry new to github was just messing with code didn't intend to push. Was only trying to change something on code (text was the easiest to edit) in branch to master. But got it all wrong. If it happens again just ignore.

Sorry Kevin.

-----Original Message----- From: "robman" notifications@github.com Sent: ‎8/‎5/‎2015 12:38 AM To: "buildar/getting_started_with_webrtc" getting_started_with_webrtc@noreply.github.com Cc: "kevinkoda" kevin@kodacall.com Subject: Re: [getting_started_with_webrtc] Up (#5)

Hi @kevinkoda we won't accept this pull request as none of the changes I can see are actually improving or extending this code. In fact in at least 2 places you have removed the reference to our authorship which is a breach under the open source license - please restore this attribution if you intend to keep using this code. The other changes are adding things like your fixed ip address and port. This is obviously something each user should set and a fixed ip address shouldn't be included in this type of example code. — Reply to this email directly or view it on GitHub.

robman commented 9 years ago

No problems @kevinkoda - now you know what that button does 8)