search

buildasaurs / XcodeServerSDK

Access Xcode Server API with native Swift objects.
MIT License
399 stars 30 forks source link

Add tvOS specification #117

Closed cojoj closed 8 years ago

cojoj commented 8 years ago

@czechboy0 I'm wondering what more do we provide on DeviceSpecification?

Fixes #116.

buildasaur commented 8 years ago

Result of Integration 1

Duration: 1 minute and 37 seconds Result: Perfect build! All 73 tests passed. :+1: Test Coverage: 56%.

czechboy0 commented 8 years ago

Since each new platform is a bit fiddly, after you apply all your changes please try to create a Bot with the SDK and make sure the Bot finishes successfully. Thanks!

czechboy0 commented 8 years ago

@cojoj, sorry I completely missed that you pushed more commits. This looks great, have you actually tried creating Bots with the tvOS platform on Xcode Server and made sure they succeed? If so I'll merge it :)

cojoj commented 8 years ago

@czechboy0, I haven't tested it yet cause I'v found creating Bot some sort of a big hustle and I haven't got enough time for this, but will do it soon.

BTW, I really think that amount of work we need to put into creating a Bot from scratch could be a PITA πŸ˜“ Calling integration is easy and so on, but creating a Bot is mostly a manual task and it requires a lot of input data...

cojoj commented 8 years ago

Even from the official docs it looks like a Bot Configuration is a PITA... πŸ˜“

buildasaur commented 8 years ago

Result of Integration 1

Duration: 1 minute and 22 seconds Result: Perfect build! All 69 tests passed. :+1: Test Coverage: 55%.

cojoj commented 8 years ago

With some help from #121 I was finally able to test that we can createBot using XcodeServerSDK and targeting tvOS. This means we're now supporting ο£ΏπŸ“Ί!

Also, XcodeServerSDK.podspec was updated to support tvOS and a small mention in README was also fixed, so it resembles the real state of the project πŸ‘Œ

This PR is ready to merge! πŸ˜‰ (sorry for the delay, but too much on my mind ATM)

buildasaur commented 8 years ago

Result of Integration 1

Duration: 1 minute and 3 seconds Result: Perfect build! All 70 tests passed. :+1: Test Coverage: 55%.

czechboy0 commented 8 years ago

Amazing work, @cojoj, thanks for taking the time to do this Sherlock work. I'll make a release with tvOS support in a couple of minutes.

czechboy0 commented 8 years ago

Actually, I can't :laughing: @cojoj I can't install Xcode 7b3, so I tvOS is still an unrecognized platform on my release Xcode 7. Will have to wait a couple of days then, sorry :/ (Will try to install Xcode 7b2 tomorrow, b3 just doesn't work for me).

czechboy0 commented 8 years ago

Dependency: https://github.com/czechboy0/BuildaUtils/issues/7