modelCode, modelName and modelUTI made optional in Device server entity

MaxDesiatov commented 8 years ago

This is a fix for https://github.com/czechboy0/Buildasaur/issues/283. As far as I understood, the Xcode Server instance had a few devices that were disconnected, but still in the list not having these properties, which was triggering JSON parsing issues.

voidrender commented 8 years ago

It looks like proxied devices can be missing a deviceType as well, so it will need the same treatment as the others. With that change, your PR works perfectly for me (at least in Buildasaur).

Here's a snippet from the getDevices call that shows my  Watch as missing the deviceType field:

{
        "_id" = dc092852df88fd1856281afea400598d;
        "_rev" = "646-2e7eb79be31cac5e72283aab895305bf";
        activeProxiedDevice =         {
            architecture = armv7k;
            connected = 1;
            deviceUDID = <redacted>;
            "doc_type" = device;
            enabledForDevelopment = 1;
            identifier = <redacted>;
            isServer = 0;
            modelCode = "Watch1,2";
            modelName = "Apple Watch 42mm";
            modelUTI = "com.apple.watch-42mm-1";
            name = "Isaac's Apple\U00a0Watch";
            osVersion = "2.2";
            platformIdentifier = "com.apple.platform.watchos";
            retina = 0;
            simulator = 0;
            supported = 1;
            tinyID = 941EB95;
            trusted = 1;
        };