search

buildasaurs / XcodeServerSDK

Access Xcode Server API with native Swift objects.
MIT License
398 stars 30 forks source link

Move API calls to separate files #47

Closed cojoj closed 9 years ago

cojoj commented 9 years ago

At the moment, all API calls are stored in XcodeServer.swift. It'd be advisable to move the to separate files and make extensions from them as the number of API calls may increase in the future.

I suggest separating them by type eg. XcodeServer+Bots will store all Bot related API calls, XcodeServer+Integrations will handle Integration and so on...

I don't know what's the proper naming convention and used well know convention from Objective-C. We can stick to this or decide on different style.

This issue is blocked until #44 is completed as this one may introduce some merge conflicts.

cojoj commented 9 years ago

@czechboy0 please hold with work in XcodeServer class as I'm planning to apply proposed changes in this issue. I'll probably do it today.

It's already a pain in the ass working with XcodeServer class in #48 so it's high time to do some clean up! 😉

czechboy0 commented 9 years ago

Go for it, I don't have any outstanding work on a branch (a rare moment, use it). I was working on Buildasaur the other day, migrating that beast to Swift 2.

czechboy0 commented 9 years ago

Another one: #55.

cojoj commented 9 years ago

Platform and Device added here: #57

czechboy0 commented 9 years ago

Finished by #58.