search

buildasaurs / XcodeServerSDK

Access Xcode Server API with native Swift objects.
MIT License
399 stars 30 forks source link

Add missing API calls: manage hosted repositories, get integrations #48

Closed cojoj closed 9 years ago

cojoj commented 9 years ago

This is the first commit for the series of Let's support official API. This is a PR for #40 and it'll take a while to complete, especially that some majore changes are being made in #44.

Fell free to review, comment and suggest changes 👀

cojoj commented 9 years ago

@czechboy0 @esttorhe please review Repository struct. I wonder if it needs graceful way of breaking or something or can it stay the way it is now? The problem may occur when we pass other value than Int to httpAccessType or sshAccessType but I guess it'll never happen...

czechboy0 commented 9 years ago

:+1:

cojoj commented 9 years ago

getRepositories() and createRepository() are available, working and with header documentation. Also 100% unit tests coverage for Repository class 😉

Please review this and add your 2 cents 💵 (@esttorhe I'm talking to you 😆)

cojoj commented 9 years ago

@czechboy0 I've changed the code to your suggestions, so feel free to review it one more time 👀

If you decide that what I've written in this PR is good enough to be merged please do so. I'd rather create new PR for other functionality not to confuse anyone.

czechboy0 commented 9 years ago

Great stuff, I just added a couple minor comments. Once you fix those, I'll happily merge this! Just one more thing - feel free to also change the readme to account for the API calls you just added! We want to be proud of how much we support! :blush:

czechboy0 commented 9 years ago

Amazing work. Thank you @cojoj! :+1: