search

buildasaurs / XcodeServerSDK

Access Xcode Server API with native Swift objects.
MIT License
399 stars 30 forks source link

Move API routes to separate files #54

Closed cojoj closed 9 years ago

cojoj commented 9 years ago

As agreed in #47 I'm progressively moving API routes from rather long XcodeServer class file to separate extension files.

There's a new folder in project directory which holds those extensions. I've decided to follow well-know naming pattern from Objective-C (currently no standard for Swift has been set), so each extension will be named like: XcodeServer+RoutesType.swift.

One important thing, to categorize API routes I've decided to follow convention Apple is using in Xcode Server JS files which can be found if you go to:

/Applications/Xcode.app/Contents/Developer/usr/share/xcs/xcsd/route

IMHO, this is a good choice, so we can easily get back to those at any time 😉

czechboy0 commented 9 years ago

:+1: Way to go. I'd be even up for merging these piece by piece instead of waiting for a mega-PR with all the files split. What do you think?

cojoj commented 9 years ago

We can split or I'll just push to this PR gradually and you can review 😃 Up to you, boss!

czechboy0 commented 9 years ago

Yeah I looked at it and as long as it compiles and I didn't miss anything, I'd prefer to merge it and always create new PRs for new pieces of work. This will also allow others to work on any part of the codebase again :wink:

So I'm assuming this compiles just fine right?

cojoj commented 9 years ago

Yep, compiles, tests pass - we're good to go! So If you like to split these, this one seems to be ready 😉

czechboy0 commented 9 years ago

Cool. I just removed the [WIP] from the name so that it looks nicer in the changelog :wink:

czechboy0 commented 9 years ago

Awesome, thanks as always! :+1: