search

buildasaurs / XcodeServerSDK

Access Xcode Server API with native Swift objects.
MIT License
399 stars 30 forks source link

Add test for fetching repositories #63

Closed cojoj closed 9 years ago

cojoj commented 9 years ago

As I pointed in #45 I've witnessed some twisted behaviors of test coverage - indicates that not all of my code is covered while breakpoints execute in not covered part of code... Maybe some ideas?

Anyway, this code works fine and all tests are passing on both iOS and OS X.

czechboy0 commented 9 years ago

Awesome discussion here, @cojoj. I'm glad we talked through the strategy for writing the API tests (which I've never done before, so I'm learning as I go as well). Let me know when you push the changes and I'll merge this beauty.

cojoj commented 9 years ago

Same here, first time doing things like this but it's really cool (At work there's always not much time to write stuff like this)!

TBH, I won't be happy with this one until Apple fixes this code coverage 😡

czechboy0 commented 9 years ago

Yeah let's hope they fix it soon. Because I also want to add reporting of code coverage to Buildasaur, so it better be accurate.

buildasaur commented 9 years ago

Result of integration 1 Integration took 42 seconds. Perfect build! All 22 tests passed. :+1:

cojoj commented 9 years ago

Of course they've passed... Some really good folks wrote them 😎

czechboy0 commented 9 years ago

Testing my new Buildasaur beta with Xcode 7 support. Seems to work so from now on we'll have PR testing! :)

czechboy0 commented 9 years ago

Btw can you make those changes suggested in comments above please, @cojoj?

cojoj commented 9 years ago

Give me a sec... Just got to the office and need some coffee ☕️

czechboy0 commented 9 years ago

Haha sorry didn't mean to rush you, just wanted us to not forget about it :)

cojoj commented 9 years ago

@czechboy0 please review... I've made other Asserts order-proof too.

buildasaur commented 9 years ago

Result of integration 2 Integration took 25 seconds. Perfect build! All 22 tests passed. :+1:

czechboy0 commented 9 years ago

Awesome as always, thanks @cojoj! :tada:

czechboy0 commented 9 years ago

And FWIW, our test coverage is 26% right now. But obviously, tests like these will not affect the code coverage metric, but they're extremely important in making sure all the pieces actually fit together (and don't break with future changes). Integration/API tests FTW!

cojoj commented 9 years ago

Great! As we're settled and my allergies don't let me lead a normal life I'll probably be bale to write some of these during weekend.

Cheers 🍻