search

buildasaurs / XcodeServerSDK

Access Xcode Server API with native Swift objects.
MIT License
399 stars 30 forks source link

XcodeServerEndpoints refactoring proposition #79

Closed pmkowal closed 9 years ago

pmkowal commented 9 years ago

Hi guys, recently I was playing a little bit with Xcode Server and I would be glad to help you i.e. increasing test coverage.

After look at the project, I thought it would be good to test e.g. endpointURL method in the XcodeServerEndpoints class. But since it is a private method, I would suggest to move this method to a seperate class and make this method internal. What do you think?

czechboy0 commented 9 years ago

Hi @pmkowal,

thanks! That would be great if you could help out. Yeah it makes sense to make endpointURL internal (just remove private), but I don't think you need to move it to another class.

pmkowal commented 9 years ago

@czechboy0 ok, so I will do it as you proposed. I just thought it would be good to share the responsibility of creating requests and providing endpoints between seperate classes.