search

buildaworldnet / IrrlichtBAW

Build A World fork of Irrlicht
http://www.buildaworld.net
Apache License 2.0
122 stars 28 forks source link

Minor CMake issue (useless targets fail) #269

Open devshgraphicsprogramming opened 5 years ago

devshgraphicsprogramming commented 5 years ago

Excerpt from MSVC build log

14>------ Build started: Project: extinst_tables, Configuration: Debug x64 ------
10>Update build-version.inc in the Shaderc build directory (if necessary).
10>'PYTHON_EXE-NOTFOUND' is not recognized as an internal or external command,
10>operable program or batch file.
10>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 9009.
10>Done building project "build-version.vcxproj" -- FAILED.
13>Check copyright
13>'PYTHON_EXE-NOTFOUND' is not recognized as an internal or external command,
13>operable program or batch file.
13>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 9009.
13>Done building project "check-copyright.vcxproj" -- FAILED.
15>------ Build started: Project: shaderc_combined_genfile, Configuration: Debug x64 ------
16>------ Build started: Project: glslc_exe, Configuration: Debug x64 ------
16>main.cc
16>path_to_git_repo_root_redacted\3rdparty\shaderc\glslc\src\main.cc(203): fatal error C1083: Cannot open include file: 'build-version.inc': No such file or directory
16>Done building project "glslc_exe.vcxproj" -- FAILED.

it looks like shaderc CMake subfolder includes some spurious targets that are not really needed and its a bit distressing for the user to see that the INSTALL target fails.

Any ideas @manhnt9 or @Crisspl ?

manhnt9 commented 5 years ago

CMake couldn't find Python in your system.

manhnt9 commented 5 years ago

It may relates to wrong CMake code I pointed out in https://github.com/buildaworldnet/IrrlichtBAW/issues/264#issuecomment-486497773, PR for that is coming.

devshgraphicsprogramming commented 5 years ago

Probably doesn't relate to the "wrong" CMake code (because that code achieves intended effect on Windows).

14>------ Build started: Project: extinst_tables, Configuration: Debug x64 ------
15>------ Build started: Project: shaderc_combined_genfile, Configuration: Debug x64 ------
16>------ Build started: Project: glslc_exe, Configuration: Debug x64 ------

Its just some extra targets being built that are useless

manhnt9 commented 5 years ago

I noticed something strange about this too. Before I didn't have other 3rdparty build errors. But today I have it complaining there's not enough dependencies for tests, etc which should be skipped. After changing option to set the error is gone.

devshgraphicsprogramming commented 5 years ago

I still get those extra useless targets being built

manhnt9 commented 5 years ago

Try setting FORCE for set commands in 3rdparty's CMake or clear build folder and run CMake again.

devshgraphicsprogramming commented 5 years ago

@manhnt9 you were doing something with Python3 correct?

manhnt9 commented 5 years ago

Not anymore, I intended to use Mercurial bridge for irrbaw but it was buggy so I didn't go further with that.

devshgraphicsprogramming commented 3 years ago

@AnastaZIuk can you take a look at this?