Warnings elimination

[AnastaZIuk]

status:

• entry warnings amount: over 6073
• flags: -Wall
• compiler: msvc

[devshgraphicsprogramming]

Prefer static_cast<T>(var) to C-style cast (T)var, C-style cast will cast anything to anything pretty much !

careful with decltype(variable) especially with regards to ints, and similar, because decltype(var) on something that was declared as T var actually evaluates to T& or const T& (depending on current scope's access const qualifiers), and you really dont want to be casting constant literals to references (this ties into why you want to use static_cast and not C-style cast).

You'd actually need a std::decay for that... ask @Crisspl how to best handle

[AnastaZIuk]

Prefer static_cast<T>(var) to C-style cast (T)var, C-style cast will cast anything to anything pretty much !

careful with decltype(variable) especially with regards to ints, and similar, because decltype(var) on something that was declared as T var actually evaluates to T& or const T& (depending on current scope's access const qualifiers), and you really dont want to be casting constant literals to references (this ties into why you want to use static_cast and not C-style cast).

You'd actually need a std::decay for that... ask @Crisspl how to best handle

I need to change for static_cast, but I find it probably not true (quite) with evaluating to T& or const T&, since it depends on the way you call decltype

[devshgraphicsprogramming]

I need to change for static_cast, but I find it probably not true (quite) with evaluating to T& or const T&, since it depends on the way you call decltype

I think static_cast<decltype()> should protect us against most things

[AnastaZIuk]

I need to change for static_cast, but I find it probably not true (quite) with evaluating to T& or const T&, since it depends on the way you call decltype

I think static_cast<decltype()> should protect us against most things

yeah, it's true

[devshgraphicsprogramming]

Update to match the HEAD of shader_pipeline fix my comments and I'll merge

[devshgraphicsprogramming]

closing temporarily.... reopen when ready for merge