buildaworldnet / IrrlichtBAW

Build A World fork of Irrlicht
http://www.buildaworld.net
Apache License 2.0
122 stars 28 forks source link

Filters API #521

Closed AnastaZIuk closed 4 years ago

AnastaZIuk commented 4 years ago

status:

done:

devshgraphicsprogramming commented 4 years ago

Ok now only Blue Noise Dithering left to do and we're ready to merge ;)

AnastaZIuk commented 4 years ago

I think we should move IDither to asset directory

AnastaZIuk commented 4 years ago

@devshgraphicsprogramming I'm done

AnastaZIuk commented 4 years ago

CBlitFilter has worked with new API recently correctly without issues but I wonder if we should query the seed for wang hash in the way like I do it now (maybe we should change it to something like std::chrono::high_resolution_clock::now().time_since_epoch().count() or similar?)

AnastaZIuk commented 4 years ago

spotted an issue however! image it seems it isn't due to dithering - when using Identity dither it generates the same weird output on bottom and right EDIT: it's probably a bug https://github.com/buildaworldnet/IrrlichtBAW/issues/460#issuecomment-683741305

devshgraphicsprogramming commented 4 years ago

CBlitFilter has worked with new API recently correctly without issues but I wonder if we should query the seed for wang hash in the way like I do it now (maybe we should change it to something like std::chrono::high_resolution_clock::now().time_since_epoch().count() or similar?)

seed should be in the whitenoise dither's state

AnastaZIuk commented 4 years ago

CBlitFilter has worked with new API recently correctly without issues but I wonder if we should query the seed for wang hash in the way like I do it now (maybe we should change it to something like std::chrono::high_resolution_clock::now().time_since_epoch().count() or similar?)

seed should be in the whitenoise dither's state

okay

devshgraphicsprogramming commented 4 years ago

This should be merged into @Crisspl 's branch when its done.