search

buildbarn / bb-storage

Storage daemon, capable of storing data for the Remote Execution protocol
Apache License 2.0
137 stars 91 forks source link

Make java_proto_library work #146

Closed Jonpez2 closed 1 year ago

Jonpez2 commented 1 year ago

Remap the outer classname so that an invocation of java_proto_library doesn't get a classname collision

EdSchouten commented 1 year ago

Looks good! Could you address the CI failure? Will merge upon success.

Jonpez2 commented 1 year ago

I think I did it

Jonpez2 commented 1 year ago

Apparently not. What is that test complaining about? I haven’t touched any byte arrays…

EdSchouten commented 1 year ago

We check in the resulting .pb.go files, to make 'go get' work. Take a look at the .github/workflows files to see what command you need to run to regenerate them.

Jonpez2 commented 1 year ago

OK, sorry, I'm not seeing any commands in the workflows that do anything but clang-format on the protos? I'm sorry I'm being dumb!

EdSchouten commented 1 year ago 
            find . bazel-bin/pkg/proto -name '*.pb.go' -delete || true
            bazel build $(bazel query 'kind("go_proto_library", //...)')
            find bazel-bin/pkg/proto -name '*.pb.go' | while read f; do
              cat $f > $(echo $f | sed -e 's|.*/pkg/proto/|pkg/proto/|')
            done
Jonpez2 commented 1 year ago

Oh duh my fork is out of date, I'm sorry

Jonpez2 commented 1 year ago

shall we try this one? Maybe I got it right...