search

buildbarn / bb-storage

Storage daemon, capable of storing data for the Remote Execution protocol
Apache License 2.0
142 stars 91 forks source link

Switch to static base image with Busybox shell #156

Closed ferraith closed 1 year ago

ferraith commented 1 year ago

This pull-request fixes the issue #153. In case for the Buildbarn developers it's still a goal to provide bb_storage images including a shell-like environment the underlying base image needs to be changed. From a user perspective having a shell available in a bb-storage container simplifies debugging in cloud environments a lot.

EdSchouten commented 1 year ago

Hey there! Are you aware that Kubernetes has in the meantime gained proper debug sidecar support?

https://kubernetes.io/docs/tasks/debug/debug-application/debug-running-pod/

With that in mind, I'm less inclined to accept changes like these.

ferraith commented 1 year ago

Hi Ed! Yes, I am aware for this command. It's possible to start a debug sidecar in the bb-storage pod and shelling into it. But I think the debug-feature isn't as future-rich compared to directly accessing a bb-storage container. For instance it's not possible to access files e.g. bb-storage.jsonnet in case these files aren't stored on a shared volume. Same for log files configured with logPaths. Nevertheless I could fully understand that you prefer to keep the image as distroless as possible.

EdSchouten commented 1 year ago

You can also just inspect the config file by looking at the config map, right? Logs also go to stdout and are preserved by kubelet, so there is generally no need to inspect the log files by exec’ing into the container, I guess.

ferraith commented 1 year ago

Hi Ed! Accepted, we can just close the pr in case you are fine with it.