search

buildbarn / bb-storage

Storage daemon, capable of storing data for the Remote Execution protocol
Apache License 2.0
137 stars 91 forks source link

Add Buildbarn logo svg #178

Open moroten opened 1 year ago

moroten commented 1 year ago

Supplying two logos, one with rounded ends on the lines but then also, unfortunately, manually edited after Drawio export.

I like the one with rounded line caps best but feel free to choose the one you prefer. Where shall it be integrated into the docs? Should there be a bb-docs for GitHub pages or should it be put in bb-deployments?

EdSchouten commented 12 months ago

Hey! That's awesome. I think I like the rounded one most as well.

I think that having a bb-docs repo only makes sense if we also commit to writing actual documentation. If this is not going to happen in the nearby future, maybe best to just keep it here?

moroten commented 12 months ago

I just realised that the bb-browser favicon is also a good alternative, maybe even better.

moroten commented 10 months ago

I'm happy with this update now. Will be integrated in https://github.com/buildbarn/bb-browser/pull/46.

EdSchouten commented 10 months ago

Considering that we likely want to use this all over the place (pkg/otel, bb-scheduler, bb-browser, ...), what are your thoughts on just having a pkg/logo in this repo that uses //go:embed to pull it in? That way we can easily reference it from within Go code without further trickery.

moroten commented 10 months ago

Nice idea, Ed! Updated the commit accordingly.

moroten commented 10 months ago

Can I persuade you to patch up pkg/otel/active_spans.html to make use of this?

I tried but failed to encode the favicon in the otel test. What's the best way forward?