buildbotics / bbctrl-firmware

Buildbotics CNC Controller Firmware
https://buildbotics.com/
Other
67 stars 24 forks source link

Input voltage lower than output voltage #307

Closed DougCoffland closed 2 years ago

DougCoffland commented 2 years ago

Add diode drop to input voltage measurement.

kwince commented 2 years ago

Shouldn't that be reversed? Unless the measurement is when the motor driver H-beidge is off between power pulses

On Wed, Oct 13, 2021, 9:05 AM DougCoffland @.***> wrote:

Add diode drop to input voltage measurement.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buildbotics/bbctrl-firmware/issues/307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFKN47ATF7EZQYLJVVFOLUGWU5PANCNFSM5F5SET4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

DougCoffland commented 2 years ago

Actually, I should have said subtract the diode drop from the input voltage measurement. We have a diode in there for reverse battery protection on our new product and forgot to account for it in our new power firmware.

DougCoffland commented 2 years ago

Fixed in V1.3 of power firmware