search

buildbotics / bbctrl-firmware

Buildbotics CNC Controller Firmware
https://buildbotics.com/
Other
67 stars 24 forks source link

Macro button formatting, and popup messages RegEx change #333

Closed Q1WP closed 2 years ago

Q1WP commented 2 years ago

Removed the index numbers from the macro buttons, and modified the RegEx test for popup messages so that an array can be sent from an M0 message using a # character as an array delimeter.

This should preserve original functionality of showing multiple user messages, but needs to be verified as I'm not sure what triggers multiple user messages from the system.

Post processors must be modified to actually write the M0 array message to GCode.

toolpath-message

macro-buttons

Q1WP commented 2 years ago

I had to make a change from the original pull request as there was a bug that did not process messages if they did not have a # character.

jcoffland commented 2 years ago

Great. I will review this soon. Thank you.

jcoffland commented 2 years ago

Thanks. Looks good. I'm going to make a few minor edits.

See https://github.com/buildbotics/bbctrl-firmware/commit/838f6c6d85adfca0e02c338c44ffb8f4ccb14619 and https://github.com/buildbotics/bbctrl-firmware/commit/3d8db7f4a661ba7f6f6011d4cb296b05f0d61922.