Recommendation from README provides deprecation warnings

buildbuddy-io / buildbuddy-toolchain

Bazel toolchains for BuildBuddy RBE

MIT License

12 stars 12 forks source link

Recommendation from README provides deprecation warnings #10

Open fzakaria opened 1 year ago

fzakaria commented 1 year ago

I am on bazel 6.1.2 and followed the README.

I see the following in my output -- the crosstool/toolchain stuff is still new to me so I am not sure relevant these are.

WARNING: Option 'javabase' is deprecated
WARNING: Option 'host_javabase' is deprecated
WARNING: Option 'java_toolchain' is deprecated
WARNING: Option 'host_java_toolchain' is deprecated

siggisim commented 1 year ago

Hey @fzakaria - are you referring to the toolchain instructions here? https://www.buildbuddy.io/docs/rbe-setup#toolchains

If so, we need to update them for the new Bazel 6 flags. We had a PR going for some of this a while back, but it never got merged - will update this issue once the docs are updated.

siggisim commented 1 year ago

Ah, you're referring to the README of this repo. We should update that as well.

fzakaria commented 1 year ago

The link to the toolchain also goes to the archive GitHub repo.

Yep, this is about Bazel 6

On Mon, May 8, 2023, 11:34 AM Siggi Simonarson @.***> wrote:

Ah, you're referring to the README of this repo. We should update that as well.

— Reply to this email directly, view it on GitHub https://github.com/buildbuddy-io/buildbuddy-toolchain/issues/10#issuecomment-1538850141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAETXDSX5UA332XTTEVJU73XFE4BTANCNFSM6AAAAAAXY6VLIU . You are receiving this because you were mentioned.Message ID: @.***>