search

buildbuddy-io / buildbuddy-toolchain

Bazel toolchains for BuildBuddy RBE
MIT License
12 stars 12 forks source link

container image: set 20.04 as the default image #25

Closed sluongng closed 3 months ago

sluongng commented 3 months ago

This switch the default image when using BuildBuddy toolchain to 20.04.

Note that the default image BuildBuddy is using when the image is set to empty string is still 16.04.

bduffany commented 3 months ago

Wonder if we should update the executor.default_image flag at some point to warm up this image by default instead of the ubuntu 16.04 image?

sluongng commented 3 months ago

Wonder if we should update the executor.default_image flag at some point to warm up this image by default instead of the Ubuntu 16.04 image?

We do have it included among the warm-up images here https://github.com/buildbuddy-io/buildbuddy/blob/d255d639c80dfb9a21d2b7537d8ff0c51d3186b2/enterprise/server/remote_execution/runner/runner.go#L855-L858

But I think it does make sense to change the flag default value for consistency. I will send a separate PR.