search

buildbuddy-io / buildbuddy-toolchain

Bazel toolchains for BuildBuddy RBE
MIT License
12 stars 12 forks source link

Enable bzlmod #27

Open sluongng opened 3 months ago

sluongng commented 3 months ago

Enable bzlmod for BuildBuddy toolchain

marvin-hansen commented 2 months ago

You may consider to add some parameters for configuration. For example:

// Load rules from BCR bazel_dep(name = "buildbuddy_toolchain", version = "0.1")

buildbuddy = use_extension("@buildbuddy//:extensions.bzl", "buildbuddy") buildbuddy.toolchain(llvm = true) use_repo(buildbuddy, "buildbuddy_toolchain")

// Do wee need to call register_toolchains???

I don't think the naming is too much different from what's out there. Is it perfect, no, but given that nearly all bzlmod rules follow this pattern, I would say it's not an issue. Also, for the most part people just copy & paste the declaration from the release page.

I would be open to test this rules once merged because I am converting my main repo to bzlmod and this is the last rule on my list.

realtimetodie commented 1 month ago

Hello @sluongng,

thank you for working on this

realtimetodie commented 1 month ago

@siggisim