@bazel_tools//platforms was soft-deprecated, but in Bazel 6.0.0 it's now hard-deprecated (results in a build error, saying to migrate to @platforms). It appears @platforms is supported at least as far back as 3.0.0, maybe earlier, so I figured it's probably not worth adding a version check to support earlier Bazel versions.
JDK8_JVM_OPTS will be removed in Bazel 6.x. I replaced it with the latest flag value as of Bazel 5.3.1, but conditional on the bazel version being >= 6.0, since those opts have changed across previous Bazel versions. Not exactly sure if this is the right approach, but it at least unbreaks the build that I tested in our BuildBuddy repo. Need to test with a Java action before submitting.
kevinchen-verkada
commented
1 year ago
@bazel_tools//platformswas soft-deprecated, but in Bazel 6.0.0 it's now hard-deprecated (results in a build error, saying to migrate to@platforms). It appears@platformsis supported at least as far back as 3.0.0, maybe earlier, so I figured it's probably not worth adding a version check to support earlier Bazel versions.JDK8_JVM_OPTSwill be removed in Bazel 6.x. I replaced it with the latest flag value as of Bazel 5.3.1, but conditional on the bazel version being >= 6.0, since those opts have changed across previous Bazel versions. Not exactly sure if this is the right approach, but it at least unbreaks the build that I tested in our BuildBuddy repo. Need to test with a Java action before submitting.