buildcom / BossyUI

http://www.bossyui.io/
17 stars 40 forks source link

658: Added button color, sizes, href, and base directions. #675

Closed michael-escutia closed 6 years ago

michael-escutia commented 6 years ago

I got most of what was needed done. Had issues getting the directional variation working as intended, so I left out my implementations for now. Changing it to left and right does not cause it to fall to the bottom anymore.

glawson commented 6 years ago

@mescutia95 - you have a unit test failing:

e 65.0.3325 (Linux 0.0.0): Executed 28 of 45 SUCCESS (0 secs / 0.602 secs) Chrome 65.0.3325 (Linux 0.0.0) PopoverComponent should create FAILED [object ErrorEvent] thrown Chrome 65.0.3325 (Linux 0.0.0): Executed 29 of 45 (1 FAILED) (0 secs / 0.631 secs) Chrome 65.0.3325 (Linux 0.0.0) PopoverComponent should create FAILED [object ErrorEvent] thrown e 65.0.3325 (Linux 0.0.0): Executed 30 of 45 (1 FAILED) (0 secs / 0.631 secs) e 65.0.3325 (Linux 0.0.0): Executed 31 of 45 (1 FAILED) (0 secs / 0.631 secs)

michael-escutia commented 6 years ago

I somewhat confused. Aren't those fails for a different component?

glawson commented 6 years ago

@mescutia95 - yes, but that's kind of the point of the unit test. Sometimes the changes you are working on might break other pieces of code, even outside what you touched. But we also might have a case that the unit test was bad before your checking - I'm looking into that right now.

glawson commented 6 years ago

@tabersays - needs your approval

glawson commented 6 years ago

resolves #658