search

builder-247 / node-autotip

Commandline-based autotip client for Hypixel using mineflayer
MIT License
20 stars 6 forks source link

HIDE_JOIN_MESSAGES does not account for new join / leave messages #13

Closed Moire9 closed 4 years ago

Moire9 commented 4 years ago

I would make a PR but I just cannot find the piece of code that detects this. The config setting "HIDE_JOIN_MESSAGES" does not work, as the join messages format was changed, from <playername> <left|joined> to <Guild|Friend> > <playername> <joined|left>. Do note that it is now differently colored. Example of my chat getting spammed by it: image Should be a fairly simple fix, just replace the string that is used for detection.

builder-247 commented 4 years ago

The related line is: https://github.com/builder-247/node-autotip/blob/d9feab7782a701cd56f4232b4b07dca48ba851a0/index.js#L72

Moire9 commented 4 years ago

Figures. It's the one JS file I didn't look at, and grep didn't seem to pick it up. I will create a pull request fixing this and removing Watchdog messages, which I will do in about 1.25 hours when the next watchdog message sends.

builder-247 commented 4 years ago

Closed via #16