builder555 / PineSAM

UI for Pinecil V2 - control it over BLE from your PC or your mobile.
MIT License
199 stars 11 forks source link

Windows binary version script has error with Wait-Process #148

Closed River-Mochi closed 1 year ago

River-Mochi commented 1 year ago

To Reproduce Steps to reproduce the behaviour:

  1. use start.ps1 powershell terminal script
  2. problem with $LASTEXITCODE it does not get any process ID for the Wait-process to work properly

Expected behaviour no error messages and the Wait happens.

Actual behaviour pinesam seems to work even with this error, but it would be nice to fix the script of Start.ps1 right now the Wait-Process fails and the script sends you back to command line. I tested it and $LASTEXITCODE and $pid1 and $pid2 are empty.

I'm testing some fixes now for this script and I think I have it fixed but would like advice on it since it could maybe be better.

Screenshots Windows binary error wait-process

Specs:

River-Mochi commented 1 year ago

@StevenSeifried could you try this alternate start.ps1 in Windows.

start.zip

StevenSeifried commented 1 year ago

Your script works fine. PID's are the same as in task manager

River-Mochi commented 1 year ago

I submitted PR to fix this. new script gets the real process ID and the Wait-process works.

River-Mochi commented 1 year ago

closed per PR fix.