builder555 / PineSAM

UI for Pinecil V2 - control it over BLE from your PC or your mobile.
MIT License
206 stars 11 forks source link

[CRITICAL] Tapping tempture change repeatedly causes sudden jumps and uncontrolled temps #217

Closed parkerlreed closed 2 days ago

parkerlreed commented 1 month ago

To Reproduce Steps to reproduce the behaviour:

  1. Turn on heater on Pinecil
  2. Use Pinecil interface to adjust temp clicking repeatedly

Expected behaviour Temperature to only jump by the amount of clicks registered.

Actual behaviour Temperatures rises uncontrollably.

Screenshots

https://github.com/user-attachments/assets/91043d0f-21fc-4807-b0a3-994e85870260

Specs:

Additional context

Clicking slowly works as expected, but if you tap repeatedly in either direction, the temps continues without user intervention until it starts trying to set invalid values. Was at a low temp and just wanted to go up a few degrees and ended up at max without intervention. Serious safety issue.

Tested with both Firefox and Chrome

parkerlreed commented 1 month ago

https://github.com/user-attachments/assets/749dd3b5-cb01-4a85-a4b0-8cec6505823a

If it goes on long enough the iron itself starts flashing the display like it's glitching out.

builder555 commented 1 month ago

Sounds like you found a hidden "don't tire your mouse out, I got this" feature :) Thank you for the report, I'll take a look this weekend.

builder555 commented 1 month ago

@parkerlreed do you want to try 2.2.9? I just pushed it. I didn't install arch, but I might've found the problem. If it persists, I'll set up a vm and test it out. Which desktop environment are you using?

parkerlreed commented 1 month ago

Of course I forgot to bring it with me on the trip.

Plasma Wayland

I'll update whenever I can test it.

parkerlreed commented 2 days ago

Yep all looks good