search

building-envelope-data / api

API specification to exchange data about building envelopes
MIT License
3 stars 1 forks source link

Update BED-JSON to remove placeholders for data we don't currently have #273

Closed RDmitchell closed 2 years ago

RDmitchell commented 2 years ago

Prioirty = 4

StephenCzarnecki commented 2 years ago

@christoph-maurer Can you provide an example url that still has placeholder information? So far I am not seeing any in the code and when I look at some samples from the server like

https://igsdb-icon.herokuapp.com/api/v1/products/4791/?json_format=buildingenvelopedata.org or https://igsdb-icon.herokuapp.com/api/v1/products/196/?json_format=buildingenvelopedata.org

I do not immediately see anything that looks like placeholder data.

christoph-maurer commented 2 years ago

@StephenCzarnecki I agree, I don't see placeholders anymore. I tried to validate https://igsdb-icon.herokuapp.com/api/v1/products/196/?json_format=buildingenvelopedata.org against the schema using make shell and make test. I had to change two things to make it valid. First, I deleted all lines "transmittance": null,, because null is not allowed and the key should be omitted if there is no data. Second, I exchanged "solar" by { "integral": "solar" } and the same for visible and infrared. I have added the original and the corrected file to the tests and deleted older examples from IGSDB.

StephenCzarnecki commented 2 years ago

@christoph-maurer This should hopefully be fixed now. I had errors trying to run make shell when I cloned the repo so was not able to verify with make test. But I have updated the json based on your comment so hopefully it is now correct.

christoph-maurer commented 2 years ago

@StephenCzarnecki It works fine, thank you! @RDmitchell Stephen has solved the two remaining issues. Thanks to both of you for your contributions!