building-envelope-data / api

API specification to exchange data about building envelopes
MIT License
3 stars 1 forks source link

Colors in the product data network #323

Open christoph-maurer opened 1 month ago

christoph-maurer commented 1 month ago

Currently, the product data network uses the CIELAB color space (example, schema) and IGSDB uses the [CIEXYZ color space]. There are calculations available to convert colors from CIELAB to CIEXYZ and reverse.

@RDmitchell @danielmcquillen If Fraunhofer changes from CIELAB to CIEXYZ, would it be easy for you to offer X, Y and Z in the same way as you already offer nearnormalHemisphericalVisibleTransmittances?

danielmcquillen commented 1 month ago

@christoph-maurer @RDmitchell

In IGSDBv2, the UI for the product detail page provides Tf, Rf and Rb color information in three formats:

For example, the coated product at https://igsdb-v2.herokuapp.com/products/low-e-6/

image
danielmcquillen commented 1 month ago

The json structure provided by the api provides a scaffolding for more information about color. However, at the moment most products (which have been directly imported from the IGDB) only have a few fields with actual values.

This information is located in the dictionaries within the integrated_spectral_averages_summaries list (there's usually only one dictionary, representing the summary values for the NFRC standard.

This dictionary includes the color key, which contains lab, 'rgb', and trichromatic data for each combination of reflectance front/back and direct/diffuse combinations:

image

For example:

https://igsdb-v2.herokuapp.com/api/v2/products/clr-3/

christoph-maurer commented 2 weeks ago

@danielmcquillen I like how you attach color to the integrated_spectral_averages!

When I move "color" to the "results", would it be easy for you to include it into BED-JSON data sets? Would it also be easy to return the CIE L*a*b* values in GraphQL?

danielmcquillen commented 2 weeks ago

@christoph-maurer Sure, I can look into that this week. It's probably easier to update the BED-JSON output so I'll look at that first.

danielmcquillen commented 2 weeks ago

@christoph-maurer Can you provide an example product json in BED-JSON format that demostrates where the color values (generated as part of the integrated summary values generation) would go?

christoph-maurer commented 4 days ago

@danielmcquillen Yes, I'll work on it. I will send it to you as soon as it is ready.

danielmcquillen commented 4 days ago

@christoph-maurer Awesome. I'll work with @RDmitchell and Jacob to update once you've got some guidance ready! (By the way, would it make sense to add Jacob to your repo so he can comment? https://github.com/jcjonsson ... Robin is out of the office for a couple weeks.)

christoph-maurer commented 3 days ago

@danielmcquillen Excellent idea! I have added @jcjonsson and @RDmitchell to the team EQWIN- P_associated_partners. This should give them access to all relevant repositories.