building-envelope-data / database

Reference implementation of a product data server as part of the product data network buildingenvelopedata.org
MIT License
0 stars 0 forks source link

Pass access token in body of POST request #11

Closed simon-wacker closed 2 years ago

simon-wacker commented 2 years ago

The access token https://github.com/ise621/database/blob/15a17ee4aab867d3ce3c71d0a9b5706fce5fa649/frontend/pages/upload-file.tsx#L22-L24 should not be given as URL parameter because it can be seen in plain text when the request is intercepted of reasons given in Information exposure through query strings in url like Web Logs, Browser Cache, ... How can we give the parameter in the POST body of the upload request constructed by Ant.Design? Maybe we also need to adapt the following lines in the backend controller https://github.com/ise621/database/blob/15a17ee4aab867d3ce3c71d0a9b5706fce5fa649/backend/src/Controllers/FileUploadController.cs#L110-L120