search

building-envelope-data / metabase

Metabase of the product data network buildingenvelopedata.org
2 stars 3 forks source link

operating state and `deleteInstitution` #184

Closed christoph-maurer closed 3 months ago

christoph-maurer commented 3 months ago

@shreyaponnamma has asked: "Should any changes be made to the delete button which is already there in the front end?"

@christoph-maurer answers: "I don't see a delete button in the front end. I see deleteInstitution in type-defs.graphqls. But I'm not sure if we should exchange it by makeInstitutionNotOperating."

@simon-wacker What do you recommend?

simon-wacker commented 3 months ago

@shreyaponnamma04 The delete button should stay there. Marking an institution as not operating is similar but different. Deleting institutions only works when they are not associated to any components, data formats and so forth. It can be used for example when someone creates an institution and then reconsiders it shortly after before associating anything with the institution or when there are bogus/spam institutions around created by a bot. Marking an institution as not operating though should also work when there are components, data formats and so forth associated to the institution. Not operating institutions can still be found in searches as they are still relevant in some sense, whereas deleted institutions are truly gone.

shreyaponnamma commented 3 months ago

Solved by #183