buildingSMART / IDS

Computer interpretable (XML) standard to define Information Delivery Specifications for BIM (mainly used for IFC)
https://www.buildingsmart.org/standards/bsi-standards/information-delivery-specification-ids/
Other
217 stars 66 forks source link

Test Cases Name restrictions will match any result #169

Open giuseppeverduciALMA opened 1 year ago

giuseppeverduciALMA commented 1 year ago

In the following test cases:

https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases-attribute.md#pass-name-restrictions-will-match-any-result-13 https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases-attribute.md#pass-name-restrictions-will-match-any-result-23 https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases-attribute.md#pass-name-restrictions-will-match-any-result-33

according to me "any" should be "all".

The restriction filters out many attributes (name and description), and all attributes should respect the meaning "The attribute must exist and have a non-empty value" (https://github.com/buildingSMART/IDS/blob/master/Documentation/attribute-facet.md#parameters).

aothms commented 1 year ago

I think in nearly all cases we have opted for any instead of all. E.g a concrete wall is a wall where at least one layer is made out of concrete, not all layers. Or, I need property X in pset Y or Z, not in both Y and Z. Attributes are subtle different, because the schema defines their names and cardinalities, but still I'd propose to keep the behaviour to any for consistency sake.

giuseppeverduciALMA commented 1 year ago

I agree on uniformity of behaviour, but we must consider that there are 2 cases:

in the first case, I agree that "any" is OK in the second case, however, "all" must be considered

first case example: property must have value "one|two"

second case example: exist properties with name ".test."