buildingSMART / IDS

Computer interpretable (XML) standard to define Information Delivery Specifications for BIM (mainly used for IFC)
Other
170 stars 54 forks source link

Inaccurate using of word "entity". #220

Closed I-Sokolov closed 3 months ago

I-Sokolov commented 6 months ago

I think it is incorrect using of word "entity" in https://github.com/buildingSMART/IDS/blob/master/Documentation/entity-facet.md

"Every entity in an IFC model has an "IFC Class" Name. For example, wall entities will have an IFC class of IfcWall"

In my mind "instance" should be used instead of "entity", while "entity" is a synonym of "IFC class".

Compare EXPRESS "ENTITY IfcWall..." with C++ "class IfcWall" and with EXPESS using of TYPE, Also refer to sdaiGetEntity and sdaiGetInstance

aothms commented 6 months ago

I agree! Either "entity instance" or just "instance'. A Pull Request would be great :)

I-Sokolov commented 5 months ago

Made PR https://github.com/buildingSMART/IDS/pull/230

CBenghi commented 3 months ago

Thanks @I-Sokolov, I'll close this and merge the PR before 1.0.