search

buildingSMART / IDS

Computer interpretable (XML) standard to define Information Delivery Specifications for BIM (mainly used for IFC)
Other
167 stars 52 forks source link

Remove the outdated "implementation agreement" comment lines from the schema #256

Open pasi-paasiala opened 2 months ago

pasi-paasiala commented 2 months ago

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

Here are still the lines, if the line number mentioned above doesn't work due to changes to the file:

        <!-- Please note there is an implementation agreement on the use of minOccurs and maxOccurs.
            Valid values are: 
            a. 0 to unbounded, meaning Optional
            b. 1 to unbounded, meaning Required
            c. 0 to 0, meaning Prohibited
         -->
pasi-paasiala commented 1 month ago

Also the first line:

<!-- Draft - Do not use in production -->

should be removed.

CBenghi commented 1 month ago

Hi @pasi-paasiala, we will remove the draft comment when freezing and updating the version number. Is that ok?

CBenghi commented 1 month ago

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

I think the comment is valid, and relevant.

pasi-paasiala commented 1 month ago

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

I think the comment is valid, and relevant.

True. I didn't realize that this was a recent change.