‘Prohibited’ testcases in ‘ids’ suite invalid according to latest logic

[andyward]

We've recently updated the logic around Prohibited applicability to state that these specifications should have no requirements. See here. But the following testcases violate that, and seem to be left over from the older thinking where prohibited applicability and requirements facets could be combined:

• ids/fail-prohibited_specifications_fail_if_at_least_one_entity_passes_all_requirements_3_3.ids
• ids/pass-a_prohibited_specification_and_a_prohibited_facet_results_in_a_double_negative.ids
• ids/pass-multiple_specifications_are_independent_of_one_another.ids
• ids/pass-prohibited_specifications_fail_if_at_least_one_entity_passes_all_requirements_2_3.ids
• ids/pass-prohibited_specifications_fail_if_at_least_one_entity_passes_all_requirements_1_3.ids

All 5 have applicability with maxOccurs = "0" but also have requirements facets. Adopting the latest logic now results in the tests failing incorrectly. The IDS files are correctly flagged up with warnings in the audit tool.

Solution: If these tests remain relevant I guess the requirement facets should moved to the applicability section?

[andyward]

Looks like these may have been removed as part of https://github.com/buildingSMART/IDS/commit/13371ecdfc1daaa651071154f3ee3d3216fa75d1 (in development but not yet main)