search

buildingSMART / IDS

Computer interpretable (XML) standard to define Information Delivery Specifications for BIM (mainly used for IFC)
Other
167 stars 52 forks source link

Clarification of testcase intent: partof\pass-an_optional_facet_always_passes_regardless_of_outcome_1_2 #266

Closed andyward closed 1 month ago

andyward commented 1 month ago

Could do with some clarification on what this partof\pass-an_optional_facet_always_passes_regardless_of_outcome_1_2 test-case is now testing. We had this passing previously but the latest update broke it, and I'm not sure if our implementation was ever right...

The title is a bit vague: 'An optional facet always passes regardless of outcome'. Bit I interpret the requirement as 'If there are any IFCELEMENTASSEMBLY entities they should have parts of (or be part of) any entity type via an IFCRELAGGREGATES relation'

The description indicates the facet is optional, but there's no cardinality attribute state. That seems to have been lost in the latest update,

Two questions:

  1. When traversing the relations, should we be following both the Decomposes and IsDecomposedBy IfcRelAggregate inverse relationships? i.e. is partof uni-directional or bi-directional?
  2. Should this test (and its 2/2 sibling) have optional cardinality, and if so, what should happen with an optional PartOf requirement? The latest notes are not especially clear to me
andyward commented 1 month ago

Has been removed in development branch - closing