search

buildingSMART / IFC4.3.x-development

Repository to collect updates to the IFC4.3 Specification
Other
168 stars 86 forks source link

Badly defined psets for infrastructure #308

Open Moult opened 2 years ago

Moult commented 2 years ago

Brought up here https://forums.buildingsmart.org/t/problem-with-pset-ifc4x3-rc2/3367 I have no idea but ping @SergejMuhic to take a look if still relevant.

Hello everyone,

We identified some mistake/missing for some Pset in the latest schema (IFC4x3 RC2).

In order to solve them asap during the schema development process please find below our proposal for the scope of following Psets that are badly defined:

Pset_RoadDesignCriteriaCommon : IfcRoad ;IfcReferent Pset_SumpBusterCommon : IfcSign Pset_Superelevation : IfcRoad ;IfcReferent Pset_TrafficCalmingDeviceCommon : IfcElementAssembly

Let me know your feedback about this.

Kevin.

berlotti commented 2 years ago

Seems the allocation of these Psets has changed, so assuming they are fixed now. Could someone confirm?

berlotti commented 2 years ago

@larswik

larswik commented 2 years ago

This is how it was defined from the very beginning (in the conceptual model). I suggest to stick with that: Pset_RoadDesignCriteriaCommon : IfcAnnotation/USERDEFINED Pset_SumpBusterCommon : IfcElementAssembly/SUMPBUSTER Pset_Superelevation : IfcAnnotation/SUPERELEVATIONEVENT (and Pset_Width applicable to IfcAnnotation/WIDTHEVENT) Pset_TrafficCalmingDeviceCommon : IfcElementAssembly/TRAFFIC_CALMING_DEVICE

Ping @berlotti and @aothms (affects_uml)

ccast1 commented 2 years ago

according to this, to be fixed by @aothms

berlotti commented 2 years ago

looks fixed

Moult commented 2 years ago

I see two conflicting proposals - one by Kevin who says Pset_RoadDesignCriteriaCommon : IfcRoad ;IfcReferent and one by @larswik who says Pset_RoadDesignCriteriaCommon : IfcAnnotation/USERDEFINED

Right now in the docs, I see Pset_RoadDesignCriteriaCommon : IfcRoad ;IfcReferent, which is what Kevin proposed, but in others I see what @larswik proposed.

Is it really fixed? Whose proposal should we follow? Can a domain expert confirm this?

zfgis commented 1 month ago

Generally,alignment is only a curve in the middle of the road or railway,anywhere of the curve can be calculated，the result may be a cartesian coordinates(x,y,z),etc..But when we need calculate the other place(x,y,z) of the road or railway. We need Pset_Superelevation and Pset_Width,too. So, road's coordinates system or railway's coordinates system includes alignment,superelevation and width.  Properties(DesignSpeed、DesignTrafficVolume、DesignVehicleClass、LaneWidthNumberOfThroughLanes) of the Pset_RoadDesignCriteriaCommon are main design indicators of the road. When they are defined, properties(indicators) of alignment,superelevation and width will be confirmed.  So,Alignment,Pset_Superelevation, Pset_Width and Pset_RoadDesignCriteriaCommon should put together that is better.