Move Documentation on `IfcTesselatedFaceSet.Closed` to the entity

[SergejMuhic]

Currently, the subtypes IfcTriangulatedFaceSet and IfcPolygonalFaceSet hold this text: " Depending on the value of the inherited attribute Closed the instance of "either polygonal or triangulated face set link" represents:

if TRUE, a boundary representation (or B-rep);
if FALSE, a face based surface representation.

"

Since the relocation of the Closed attribute to the base entity, I would propose moving that documentation snippet also and remove it from the subtypes.

[aothms]

For me this can also be removed. I disagree with it.

Both a BRep and a IfcFaceBasedSurfaceModel can be open or closed if you ask me. BRep is typically more about the representation mechanism [so a separation between geometrical and topological entities] that neither of these subtypes actually provides.

[SergejMuhic]

I agree partially. I have no idea what the first point on B-rep is trying to say. A B-rep is exactly as you said, a representation mechanism. It has nothing to do with surface vs body.

I guess if it is decided to keep it, a re-phrashing would be in order. Something in the line of: " if TRUE, solid/body geometry if FALSE, surface geometry " I would not remove it though. Keeping and re-phrasing would be my preference.

[TLiebich]

the current definition is not precise when refering to B-Rep. It should refer to a solid brep, based on the definition of an IfcManifoldSolidBrep - i.e. "is a solid represented as a collection of connected surfaces that delimit the solid from the surrounding non-solid"

but I would prefer to keep the definition at the implementable subtypes.

[aothms]

If you ask me, also not a solid brep. Solids can be unbounded, e.g a IfcHalfSpaceSolid. Brep is a modelling paradigm it doesn't relate to properties of the shape.