search

buildingSMART / IFC4.4.x-development

Development of IFC 4.4
Other
8 stars 6 forks source link

Update IFC.xml #26

Open larswik opened 1 year ago

larswik commented 1 year ago

All changes from the IFC Tunnel project up until now.

aothms commented 1 year ago

Thanks @larswik on first inspection I found the following minor issues. Hope you can resolve them:

IfcBorehole has 2 generalizations:

                    <packagedElement xmi:type="uml:Class" xmi:id="EAID_CC98D225_794C_1B19_E053_5801400A16D7" name="IfcBorehole" visibility="public">
                        <ownedAttribute xmi:type="uml:Property" xmi:id="EAID_83003F24_F3ED_42ce_ADD9_7D7E40C09302" name="PredefinedType" visibility="public" isStatic="false" isReadOnly="false" isDerived="false" isOrdered="false" isUnique="true" isDerivedUnion="false">
                            <type xmi:idref="EAID_C015424E_5710_4725_AA80_84F7F49C89DD"/>
                            <lowerValue xmi:type="uml:LiteralInteger" xmi:id="EAID_LI010653_F3ED_42ce_ADD9_7D7E40C09302" value="1"/>
                            <upperValue xmi:type="uml:LiteralInteger" xmi:id="EAID_LI010654_F3ED_42ce_ADD9_7D7E40C09302" value="1"/>
                        </ownedAttribute>
                        <generalization xmi:type="uml:Generalization" xmi:id="EAID_CC98D225_88FF_1B19_E053_5801400A16D7" general="EAID_CC98D225_796C_1B19_E053_5801400A16D7"/>
                        <generalization xmi:type="uml:Generalization" xmi:id="EAID_D5D0E011_24DA_4696_BFC9_D8739A02E73B" general="EAID_91095E51_08E0_4d42_982E_DDFB9C7FF23E"/>
                    </packagedElement>

There are attributes without an order tag apparently:

WARNING:root:No attribute order on IfcWellKnownText.CoordinateReferenceSystem

IfcArchElementTypeEnum is an empty enumeration. I though the code was able to deal with this and add userdefined/notdefined automatically, but appears to be not the case.

                <packagedElement xmi:type="uml:Enumeration" xmi:id="EAID_27E8865A_34F8_4f8a_9A44_3C94A9A71C7F" name="IfcArchElementTypeEnum" visibility="public"/>
aothms commented 1 year ago

There are attributes without an order tag apparently:

WARNING:root:No attribute order on IfcWellKnownText.CoordinateReferenceSystem

Which might be my error actually if you didn't touch it. It's fine. Attributes without an order tag go last, which is also where it should be in the schema.

larswik commented 1 year ago

Hi Thomas and thanks,

I can take a look at these things (including the attribute ordering while I am in there) tomorrow and update the pr.

BR Lars

Skickat från Outlook för Androidhttps://aka.ms/AAb9ysg

From: Thomas Krijnen @.> Sent: Wednesday, January 18, 2023 11:35:26 AM To: buildingSMART/IFC4.4.x-development @.> Cc: Lars Wikström @.>; Mention @.> Subject: Re: [buildingSMART/IFC4.4.x-development] Update IFC.xml (PR #26)

There are attributes without an order tag apparently:

WARNING:root:No attribute order on IfcWellKnownText.CoordinateReferenceSystem

Which might be my error actually if you didn't touch it. It's fine. Attributes without an order tag go last, which is also where it should be in the schema.

— Reply to this email directly, view it on GitHubhttps://github.com/buildingSMART/IFC4.4.x-development/pull/26#issuecomment-1386834529, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGCTEZFP4NYW64IZQNPXGPDWS7BO5ANCNFSM6AAAAAAT4Q6OSE. You are receiving this because you were mentioned.Message ID: @.***>

aothms commented 1 year ago

Sorry, these errors are triggered at the parse stage of the resulting exp and the parser halts at the first error.

We had a pt-class RINGSECTION/ROUND which is not a valid name for an express enum literal.

<packagedElement xmi:type="uml:Class" xmi:id="EAID_DA826A73_37EF_4c25_BCB1_516B1B650DF4" name="IfcTunnelPartTypeEnum.RINGSECTION/ROUND" visibility="public"/>

The uml enum item itself was simply classed RINGSECTION, since I had the changes locally a committed them (and then accidentally pushed to your fork...)