search

buildingSMART / IFC4.4.x-development

Development of IFC 4.4
Other
8 stars 6 forks source link

Can we make Layer set use "Name" as an attribute not "LayerSetName" #4

Open Moult opened 2 years ago

Moult commented 2 years ago

Reported https://forums.buildingsmart.org/t/can-we-make-layer-set-use-name-as-an-attribute-not-layersetname/3528

This is one of those things in the codebase I put a comment going "what's going on IFC".

Quoted:

Everything else uses "Name" except for IfcMaterialLayerSet and it's inconsistent :)

TLiebich commented 2 years ago

guess purely a legacy issues. Since attribute namesdo not show up in the exchange file I would opt for renaming it in favor of consistency.

Moult commented 2 years ago

+1. @aothms ? Something to move into the decided phase?

aothms commented 2 years ago

No particular opinion. It's indeed inconsistent, but changing the name is also somewhat annoying for implementers. I think I'd postpone this to a major release, but I'm also realty really fine to make the change.

pjanck commented 2 years ago

Since attribute names do not show up in the exchange file I would opt for renaming it in favor of consistency.

That is true, however it does show up in early bind libraries, like the one in TUM OpenInfraPlatform. So I'd agree with

somewhat annoying for implementers. I think I'd postpone this to a major release

Moult commented 2 years ago

Marking as onhold :) After 4.3 we can finally make this change! :D