Open BernhardWehrle opened 3 years ago
Do you want only a IFC-File?
AKG Software Consulting GmbH Bernhard Wehrle Entwicklung
Uhlandstraße 12 79423 Heitersheim Germany
Tel.: +49 (0)7634 5612-0 Fax: +49 (0)7634 5612-300 E-Mail: wehrle@akgsoftware.de Internet: www.akgsoftware.dehttp://www.akgsoftware.de
Geschäftsführer: Dipl.-Ing. Artur K. Günther, Dipl.-Ing. Arno Brüggemann, Dipl.-Ing. (FH) Bernhard Feser, Dipl.-Ing. Jens Günther Sitz der Gesellschaft: Heitersheim, HRB 310383 (Amtsgericht Freiburg)
Von: Stefan Jaud notifications@github.com Gesendet: Donnerstag, 28. Januar 2021 09:58 An: buildingSMART/Sample-Test-Files Sample-Test-Files@noreply.github.com Cc: Bernhard Wehrle wehrle@akgsoftware.de; Author author@noreply.github.com Betreff: Re: [buildingSMART/Sample-Test-Files] UT_IfcAlignment_IfcCourse_IfcSectionedSolidHorizontel (#101)
Externe E-Mail: Vorsicht beim Öffnen von Anhängen und Klicken auf Links!
@pjanck requested changes on this pull request.
I really like the many different formats submitted for reference!
One request: please use IfcSectionedSolidHorizontal consistently - sometimes you use "horizontAl", sometimes "horizontEl" - the correct one would be the former.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/buildingSMART/Sample-Test-Files/pull/101#pullrequestreview-578109799, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJHOJH5TZGF6J5O6V7MGRX3S4ERMTANCNFSM4WUY64RA.
Hi Bernhard,
other files are very welcome! I think that this way others will be able to double-check their implementations accordingly.
My comment was addressing the typos in your readme and file names. Sometimes you've used "E", sometimes an "A" (correct) in IfcSectionedSolidHorizont*l
.
We're moving to the new repository: https://github.com/bSI-InfraRoom/IFC-infra-unit-test
Please open a new pull request there and close this one.
Changes
35 = IFCALIGNMENTHORIZONTAL('397AcFNgJJlq9EY2eHiJZv', $, $, $, $, $, $, 0., $);
38 = IFCCARTESIANPOINT((513210., 5454110.));
41 = IFCCARTESIANPOINT((513210., 5454110.));
ATTENTION: This template provides structure for
General pull request
Fixes # . reference the issue fixed through this pull request
Changes and improvements proposed by this pull request
Use
@[username]
to gain attention by potential reviewers.IFC4.3 Unit test
Unit test
provide a short description
Review requested
@pjanck
Link to external documentation
optional
Instructions
[UT] <title>
to enable easier managementinfra depl